Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhel: fix crash when PartitionType() is requested #1020

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Nov 7, 2024

This commit fixes a crash in when the rhel ImageType.PartitionType() is called, here the BasePartitionTables function pointer is sometimes not initialized (e.g. in the centos9/edge-commit image type).

This commit fixes a crash in when the rhel ImageType.PartitionType()
is called, here the BasePartitionTables function pointer is sometimes
not initialized (e.g. in the `centos9/edge-commit` image type).
@mvo5 mvo5 requested a review from thozza November 7, 2024 10:05
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!!

@achilleas-k achilleas-k added this pull request to the merge queue Nov 7, 2024
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

pkg/distro/rhel/imagetype.go Show resolved Hide resolved
Merged via the queue into osbuild:main with commit fb51dd3 Nov 7, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants