imagefilter: add ResultFormatter type to support flexible output
#1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
commented
Nov 7, 2024
| Name string `json:"name"` | ||
| } | ||
|
|
||
| type filteredResultJSON struct { |
There was a problem hiding this comment.
We need to decide a bit how much we want to expose here, it will become an API so I started very minimal, I played with this a bit and added everything in 37c0921 just to see what it would look like. The result is something like:
{
"distro": {
"name": "rhel-10.0",
"Codename": "",
"Releasever": "10",
"OsVersion": "10.0",
"ModulePlatformID": "platform:el10",
"Product": "Red Hat Enterprise Linux",
"OSTreeRef": "rhel/10/%s/edge"
},
"arch": {
"name": "x86_64"
},
"image_type": {
"name": "vmdk",
"bootmode": "hybrid",
"filename": "disk.vmdk",
"MIMEType": "application/x-vmdk",
"OSTreeRef": "",
"ISOLabel": "",
"Size": 1,
"PartitionType": "gpt",
"BuildPipelines": [
"build"
],
"PayloadPipelines": [
"os",
"image",
"vmdk"
],
"PayloadPackageSets": [
"blueprint"
],
"Exports": [
"vmdk"
]
}
},
{
"distro": {
"name": "rhel-10.0",
"Codename": "",
"Releasever": "10",
"OsVersion": "10.0",
"ModulePlatformID": "platform:el10",
"Product": "Red Hat Enterprise Linux",
"OSTreeRef": "rhel/10/%s/edge"
},
"arch": {
"name": "x86_64"
},
"image_type": {
"name": "wsl",
"bootmode": "none",
"filename": "disk.tar.gz",
"MIMEType": "application/x-tar",
"OSTreeRef": "",
"ISOLabel": "",
"Size": 1,
"PartitionType": "",
"BuildPipelines": [
"build"
],
"PayloadPipelines": [
"os",
"archive"
],
"PayloadPackageSets": [
"blueprint"
],
"Exports": [
"archive"
]
}
}
...(just to give a flavor what is there)
[edit: fixed a bug in the generation]
There was a problem hiding this comment.
Add a few config parameters and package lists to this and we have a good way to "dump" image definitions in a portable way ^_^
mvo5
commented
Nov 7, 2024
mvo5
force-pushed
the
imagefilter-fmt
branch
2 times, most recently
from
f574956 to
21b1ec1
Compare
This commit adds a new `ResultFormatter` interface that supports outputing the results as text or JSON. Note that the text output should be copy/paste friendly, i.e. the "image-builder" cmdline (or other consuemrs) should support: ``` $ image-builder manifest centos-9 type:qcow2 arch:s390 $ image-builder build centos-9 type:qcow2 arch:x86_64 ``` (and of course `build` will need to error there is an architecture mistach like host-arch != target-arch).
mvo5
force-pushed
the
imagefilter-fmt
branch
from
21b1ec1 to
ff00f63
Compare
achilleas-k
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
ResultFormatterinterface that supportsoutputing the results as text or JSON.
(this is another splitout from #997)