Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk: separate most tests from package #1014

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

achilleas-k
Copy link
Member

Separate most disk tests into internal and external ones.

  • disk_test.go: was internal (package disk) and is now external (package disk_test)
  • Function entityPath() and method PartitionTable.findDirectoryEntityPath() are now exported for tests in export_test.go
  • Test partition tables moved to partition_table_internal_test.go and exported.
  • Unique string tests moved to new file: disk_internal_test.go

Separate most disk tests into internal and external ones.

- disk_test.go: was internal (package disk) and is now external (package
  disk_test)
- Function `entityPath()` and method
  `PartitionTable.findDirectoryEntityPath()` are now exported for tests
  in export_test.go
- Test partition tables moved to partition_table_internal_test.go and
  exported.
- Unique string tests moved to new file: disk_internal_test.go
@achilleas-k achilleas-k requested a review from mvo5 November 4, 2024 16:28
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@achilleas-k achilleas-k added this pull request to the merge queue Nov 4, 2024
Merged via the queue into osbuild:main with commit 4c626ac Nov 4, 2024
16 of 19 checks passed
@achilleas-k achilleas-k deleted the disk/test/separate-internal branch November 7, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants