reporegistry: move to logrus instead of log.Printf() #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
previously approved these changes
Oct 29, 2024
thozza
reviewed
Oct 30, 2024
mvo5
force-pushed
the
reporegistry-logrus
branch
from
9c0423f to
8ee8ef4
Compare
thozza
reviewed
Oct 31, 2024
achilleas-k
reviewed
Oct 31, 2024
This commit removes the direct log.Printf() from the repo loading. With the coming daemonless CLI frontend to image building these prints are distracting for our users. Instead logrus (which is already used in the images library) is used with the appropriate "Infof()" and "Warnf()" methods.
mvo5
force-pushed
the
reporegistry-logrus
branch
from
8ee8ef4 to
6e4b2b3
Compare
achilleas-k
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the direct log.Printf() from the repo loading. With the coming daemonless CLI frontend to image building these prints are distracting for our users.
Instead logrus (which is already used in the images library) is used with the appropriate "Debugf()" and "Warnf()" methods.