Skip to content

Commit

Permalink
upload: disable koji when building with cgo
Browse files Browse the repository at this point in the history
koji requires the kttp kerberos module which requires cgo so when
build without cgo kerberos uploads are currently not supported.
  • Loading branch information
mvo5 committed Dec 20, 2024
1 parent 8bc3938 commit 8299f82
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:

- name: Run unit tests without CGO
# keep tags in sync with BUILDTAGS_CROSS in https://github.com/containers/podman/blob/2981262215f563461d449b9841741339f4d9a894/Makefile#L85
run: CGO_ENABLED=0 go test -v -tags "containers_image_openpgp exclude_graphdriver_btrfs exclude_graphdriver_devicemapper exclude_graphdriver_overlay" ./...
run: CGO_ENABLED=0 go test -tags "containers_image_openpgp exclude_graphdriver_btrfs exclude_graphdriver_devicemapper exclude_graphdriver_overlay" ./...

- name: Run depsolver tests with force-dnf to make sure it's not skipped for any reason
run: go test -v -race ./pkg/dnfjson/... -force-dnf
Expand Down
5 changes: 5 additions & 0 deletions pkg/upload/koji/koji.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
//go:build cgo

// koji requires the kttp kerberos module which requires cgo so when
// build without cgo kerberos uploads are currently not supported

package koji

import (
Expand Down

0 comments on commit 8299f82

Please sign in to comment.