cmd: run simple riscv64 cross build as part of the integration tests #136
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
riscv-cnt-buildroot
branch
3 times, most recently
from
c56cca2 to
1528ffd
Compare
mvo5
force-pushed
the
riscv-cnt-buildroot
branch
3 times, most recently
from
77d0c11 to
66d519c
Compare
mvo5
commented
Feb 20, 2025
test/test_container.py
Outdated
| # XXX: we should encode this in images proper | ||
| # note that we need the "fedora-toolbox" container as the regular one | ||
| # does not contain python3 | ||
| images_experimental_env = "IMAGES_EXPERIMENTAL=buildroot=fedora.riscv.rocks:3000/davidlt/fedora-toolbox:41" |
There was a problem hiding this comment.
This will need to use ghcr.io/mvo5/fedora-buildroot:41
which is just:
FROM fedora.riscv.rocks:3000/davidlt/fedora-toolbox:41
RUN dnf install -y selinux-policy-targeted policycoreutils dosfstools
# our hardcoded build.go:NewBuildrootFromContainer expects a /ostree
# in the selinux labeling. workaround here for now.
RUN mkdir -p /ostreeThere was a problem hiding this comment.
I put them now into https://github.com/mvo5/buildroot-containers
There was a problem hiding this comment.
Note that this is an intermediate solution, once the upstream fedora-toolbox container installs policycoreutils this container is no longer needed and we can use the upstream one.
mvo5
force-pushed
the
riscv-cnt-buildroot
branch
2 times, most recently
from
af169e1 to
ba4e229
Compare
mvo5
changed the title
This commit skips the arch checks if the experimental "bootstrap" option is used. The main use-case of this option is to bootstrap a foreign architecture so just assume that and skip arch checks when set. This allows to write: ``` $ IMAGE_BUILDER_EXPERIMENTAL=buildroot=ghcr.io/mvo5/fedora-buildroot:41 \ ./image-builder build --arch=riscv64 minimal-raw --distro=fedora-41 ``` and do a riscv64 cross arch build.
This commit uses the new experimental `bootstrap` flag to perform a cross arch build for riscv64.
mvo5
changed the title
mvo5
force-pushed
the
riscv-cnt-buildroot
branch
from
ba4e229 to
84e0dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch shows how to cross arch build traditional images. It also allows to skip
the cross-arch build restriction when
IMAGE_BUILDER_EXPERIMENTAL=bootstrap=...is set.The not-so-nice part of this work is that we need to pick the the right container via
IMAGE_BUILDER_EXPERIMENTAL=bootstrap=...currently. Fortunately almost any upstream container will do as long as it has rpm and setfiles (policycoreutils).We really should teach images to map containers to buildroots so that we don't need to do this.
Ideally this would be in "images" itself, I guess we will merge ibcli and images eventually anyway.