Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration test for the new swap customization #745

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Dec 5, 2024

This commit adds an integration test for the new swap disk customization that got added to the images library in PR osbuild/images#1072

@mvo5 mvo5 force-pushed the bib-tests-add-swap branch 4 times, most recently from c185e5b to d9d9390 Compare December 5, 2024 16:12
@mvo5 mvo5 force-pushed the bib-tests-add-swap branch from d9d9390 to a4f4451 Compare December 5, 2024 16:12
@mvo5 mvo5 marked this pull request as ready for review December 5, 2024 16:13
This commit adds an integration test for the new swap disk
customization that got added to the `images` library in PR
osbuild/images#1072

Also extends the LVM test to include swap on lvm.
@mvo5 mvo5 force-pushed the bib-tests-add-swap branch from a4f4451 to b69995c Compare December 5, 2024 16:17
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I appreciate the simplification of the list of test cases, it's now much more straightforward. I found two minor issues inline.

test/test_manifest.py Outdated Show resolved Hide resolved
test/testutil.py Outdated Show resolved Hide resolved
@mvo5 mvo5 requested a review from ondrejbudai December 5, 2024 16:27
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ondrejbudai ondrejbudai enabled auto-merge December 5, 2024 16:41
@ondrejbudai ondrejbudai added this pull request to the merge queue Dec 5, 2024
Merged via the queue into osbuild:main with commit 10fb0a4 Dec 5, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants