fix: install anaconda-install-img-deps package in anaconda installers. #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
reviewed
Nov 11, 2024
| @@ -75,7 +75,6 @@ anaconda-iso: | |||
| - perl-interpreter | |||
| - pigz | |||
| - plymouth | |||
| - python3-pam | |||
There was a problem hiding this comment.
Unsure about this removal, I see it mentioned in the Fedora IoT issue but I don't see python3-pam as a dep of -img-deps except in:
$ fedrq whatrequires python3-pam | grep anaconda
anaconda-install-img-deps-42.13-1.fc42.x86_64
There was a problem hiding this comment.
Perhaps the removal of python3-pam should only be applied on Fedora 42?
There was a problem hiding this comment.
Yes, it is a dependency in the versions that require it (Fedora 42 at this point):
sudo dnf repoquery --requires anaconda-install-img-deps
Updating and loading repositories:
Fedora rawhide openh264 (From Cisco) - x86_64 100% | 7.7 KiB/s | 6.0 KiB | 00m01s
Fedora - Rawhide - Developmental packages for the next Fedora release 100% | 10.9 MiB/s | 21.9 MiB | 00m02s
Repositories loaded.
anaconda-install-env-deps = 42.13-1.fc42
brltty
createrepo_c
device-mapper-multipath
fcoe-utils >= 1.0.12-3.20100323git
gnome-kiosk
gnome-remote-desktop
gsettings-desktop-schemas
kdump-anaconda-addon
librsvg2
mesa-dri-drivers
nm-connection-editor
nvme-cli
openssl
ostree
podman
python3-pam
rpm-ostree >= 2023.2
skopeo
zram-generator-defaults
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
supakeen
approved these changes
Dec 13, 2024
According to the anaconda team we should be using the `anaconda-install-img-deps` metapackage to install all the boot.iso image dependencies. Relates: fedora-iot/iot-distro#66 Signed-off-by: Miguel Martín <[email protected]>
mvo5
force-pushed
the
update-anaconda-installer-deps
branch
from
9dfd046 to
089eee8
Compare
github-actions
bot
removed
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the anaconda team we should be using the
anaconda-install-img-depsmetapackage to install all the boot.iso image dependencies.
Relates: #707
Relates: fedora-iot/iot-distro#66
Signed-off-by: Miguel Martín [email protected]