bib: switch arch64 back from "gpt" to "dos" to unbreak all Pis with older firmware #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Mon, Aug 5, 2024, at 7:48 AM, Michael Vogt wrote:
The raspberry pi3 does not support "gpt" partition tables. This commit
moves back to "dos" for maximum compatibility.
A few points:
First personally I think in general we should discourage the “dd to disk” approach. Bib can generate an anaconda ISO which can be used for installs and Anaconda supports configuring the partition table already via kickstart. (Or one can script a stock ISO for this case too)
And speaking of that configurability I don’t see a reason we couldn’t expose something similar here. (It would be nice to be configurable in the container as well)
I get why people want to do the “dd to disk” with a SD card or equivalent but it would probably make sense to have that be an explicit operation.
|
|
Thanks for your input here, I will close it for now and if it becomes an issue we can revisit it and add a bib switch to make it an explicit operation. |
mvo5
changed the title
The raspberry pi3 and newer version with outdated firmware apparently do not support "gpt" partition tables. This commit moves back to "dos" for maximum compatibility. Once we have support to ship default partition tables inside the container we can drop this again but for now it seems the most common users of bootc on aarch64 are some variant of a RPi so ideally the experience is as smooth as possible there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I learned that this change to move to "gpt" does not only affect RPi3 but also newer PIs that have not updated their firmware yet. This commit moves back to "dos" for maximum compatibility.
Parallel to this we should IMHO ASAP support a default partition table inside the container (e.g. via /blueprint.json and advanced partitioning there) that is then read by bib and applied so that we can be maximum compatible. Unti lthat is done IMHO the default should optimize for the 90% users which I think is the RPi on aarch64.
When reviewing #582 I was a bit too enthusiastic about the de-dup (which I totally love) and overlooked that it also switches the default partition type to "gpt" on aarch. This has ramifications for the pi3 that does not support gpt. Given that the pi3 was released in 2016 and the pi4 is 2019 it is maybe okay to just not support the pi3 but I wanted to open this to make sure it's a conscious decision - alternatively we could do smarter stuff and get the partition table from the container and leave it to the container to decide what they want to support.