Honor ticket number in subject line without brackets #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced a glitch in 29b3714, which was the patch that introduced matching on email headers other than the Subject. I misinterpreted the original `preg_match()` regex, thinking that it was requiring brackets. Looking at it again today, I see that it didn't. The current one does, however, require surrounding brackets. This patch also allows for extra letters or dashes between the `#` and the ticket number. Eventually we should allow the ticket number itself to have extra characters -- be formattable. Fixes osTicket/osTicket#342
protich
added a commit
that referenced
this pull request
Jan 3, 2014
Honor ticket number in subject line without brackets Reviewed-By: Peter Rotich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a glitch in 29b3714, which was the patch that introduced matching on email headers other than the Subject.
I misinterpreted the original
preg_match()regex, thinking that it was requiring brackets. Looking at it again today, I see that it didn't. The current one does, however, require surrounding brackets.Fixes osTicket/osTicket#342