Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn argument value identified as a package #156

Closed
3 tasks
baruchiro opened this issue Sep 26, 2023 · 6 comments · Fixed by #166
Closed
3 tasks

yarn argument value identified as a package #156

baruchiro opened this issue Sep 26, 2023 · 6 comments · Fixed by #166
Assignees
@yoavsbg
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@baruchiro
Copy link
Collaborator

In the example here, the 100000 is indentified as a package, but it is not:

yarn add <yourPackage> --network-timeout 100000
@baruchiro baruchiro added bug Something isn't working good first issue Good for newcomers labels Sep 26, 2023
@rzarviv
Copy link
Contributor

rzarviv commented Sep 27, 2023

Hi @baruchiro, could you please assign me to solve this issue?

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Hey! This task was taken over a few days ago, but nothing has happened since then. Maybe the current contributor can comment on this?

@rzarviv
Copy link
Contributor

rzarviv commented Oct 5, 2023

Hey! This task was taken over a few days ago, but nothing has happened since then. Maybe the current contributor can comment on this?

I'm still working on this issue

@github-actions
Copy link

Hey! This task was taken over a few days ago, but nothing has happened since then. Maybe the current contributor can comment on this?

@github-actions
Copy link

Due to a long period of inactivity, this task was unassigned automatically.

@yoavsbg
Copy link
Contributor

yoavsbg commented Feb 17, 2024

Hi @baruchiro, could you please assign me to solve this issue?

@baruchiro baruchiro mentioned this issue Feb 18, 2024
Merged
baruchiro added a commit that referenced this issue Feb 21, 2024
@yoavsbg @baruchiro
fix: yarn argument value identified as a package (#166)
53be4e7 
Fixes #156

In case of Number, handle it as Argument and skip this word.
After the fix:
![Screen Shot 2024-02-18 at 21 42
13](https://github.com/os-scar/overlay/assets/6542413/02c26ac7-62d4-4ba0-886b-3a3b1ec0df6b)

---------

Co-authored-by: Baruch Odem (Rothkoff) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoavsbg yoavsbg

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: yarn argument value identified as a package yoavsbg/overlay
3 participants
@yoavsbg @baruchiro @rzarviv