-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/container: update grep for podman top #16567
Conversation
You need a check for podman version, otherwise this will fail in versions <4.4 |
Also, you won't be able to test this until the SR is accepted and available on TW. |
a398857
to
4c9528f
Compare
Signed-off-by: danishprakash <[email protected]>
4c9528f
to
1c8c9fc
Compare
you can test against Staging:L |
Not sure I understand that honestly. Can I not trigger a run based off my branch and then rerun the failing openQA tests? Is that possible? |
You can trigger the tests based of this branch. What @jlausuch meant, was that as podman 4.4. is currently not yet in Factory, your changes wouldn't be verified. But as podman 4.4 has been submitted to Factory and is currently staged in Staging:L, you can go to that staging project: https://build.opensuse.org/staging_workflows/openSUSE:Factory/staging_projects/openSUSE:Factory:Staging:L, pick one of the openQA tests pasted there by the openQA bot and clone the appropriate test from there. It should contain podman 4.4. |
This was merged without approvals and even without VRs... this could break things everywhere if not verified. Please don't do this again. I just started: |
Backwards compatibility VR (podman 4.3.1) https://openqa.opensuse.org/t3162577 |
tests/container: update grep for podman top
tests/container: PR review follow-up for #16567
While starting a container with --user, podman appends a /etc/passwd entry in which it uses the UID for the host/container user. Starting v4.4.1, it now replaces[1] the UID with the Username if present. Fixing the grep here to play nicely with the updated top output.
[1] - containers/podman#17174