Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/container: update grep for podman top #16567

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

danishprakash
Copy link
Contributor

@danishprakash danishprakash commented Mar 8, 2023

While starting a container with --user, podman appends a /etc/passwd entry in which it uses the UID for the host/container user. Starting v4.4.1, it now replaces[1] the UID with the Username if present. Fixing the grep here to play nicely with the updated top output.

[1] - containers/podman#17174

@jlausuch
Copy link
Contributor

jlausuch commented Mar 8, 2023

You need a check for podman version, otherwise this will fail in versions <4.4

@jlausuch
Copy link
Contributor

jlausuch commented Mar 8, 2023

Also, you won't be able to test this until the SR is accepted and available on TW.

@dcermak
Copy link
Contributor

dcermak commented Mar 8, 2023

Also, you won't be able to test this until the SR is accepted and available on TW.

you can test against Staging:L

@danishprakash
Copy link
Contributor Author

Also, you won't be able to test this until the SR is accepted and available on TW.

Not sure I understand that honestly. Can I not trigger a run based off my branch and then rerun the failing openQA tests? Is that possible?

@dcermak
Copy link
Contributor

dcermak commented Mar 8, 2023

Not sure I understand that honestly. Can I not trigger a run based off my branch and then rerun the failing openQA tests? Is that possible?

You can trigger the tests based of this branch. What @jlausuch meant, was that as podman 4.4. is currently not yet in Factory, your changes wouldn't be verified. But as podman 4.4 has been submitted to Factory and is currently staged in Staging:L, you can go to that staging project: https://build.opensuse.org/staging_workflows/openSUSE:Factory/staging_projects/openSUSE:Factory:Staging:L, pick one of the openQA tests pasted there by the openQA bot and clone the appropriate test from there. It should contain podman 4.4.

@sysrich sysrich merged commit a12470a into os-autoinst:master Mar 8, 2023
@jlausuch
Copy link
Contributor

jlausuch commented Mar 8, 2023

This was merged without approvals and even without VRs... this could break things everywhere if not verified. Please don't do this again.

I just started:
https://openqa.opensuse.org/t3162572

@jlausuch jlausuch requested a review from Vogtinator March 8, 2023 10:47
@jlausuch
Copy link
Contributor

jlausuch commented Mar 8, 2023

Backwards compatibility VR (podman 4.3.1) https://openqa.opensuse.org/t3162577

@jlausuch
Copy link
Contributor

jlausuch commented Mar 8, 2023

danishprakash pushed a commit to danishprakash/os-autoinst-distri-opensuse that referenced this pull request Mar 8, 2023
tests/container: update grep for podman top
jlausuch added a commit that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants