-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump github.com/knadh/koanf to v2.0.1 #693
Conversation
This requires adopting the koanf changes in these other projects as well:
If it works there, we can merge this :) |
@aeneasr Great - I'll do the same update for those repos as well, and link them here. |
Each repo's go.mod contains a replacement to my fork of ory/x, which should allow it to build and run tests to see if they pass. I suppose we would have to merge this PR first and then edit the other ones to remove the replacement? Not sure, up to you. |
Awesome, thank you! 🎉 Your contribution makes Ory better :) |
Could you update the PRs in the individual repos now with the official ory/x version? :) Thank you! 👍 |
Updated the other PRs to import ory/x@master. 👍 |
I also went ahead and updated fosite as well (that's the library I'm using directly). Let me know if those changes look good. I made my best guess on some updates to error-related test cases. |
Related Issue or Design Document
This updates
github.com/knadh/koanf
from v1.4.4 to v2.0.1. There are no functional changes, but the module structure was reworked to have several submodules where there were previously packages within one main module.The dependency of koanf v1 in this package is causing an issue for a module of mine that imports both koanf/v2 and a different ory package (which imports this one) because there is a new submodule in koanf/v2 with the same name as a package in v1. Go does not know how to resolve this, and it throws the following error:
Replacing ory/x with my fork solves the problem.
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments