Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authz): Add remote_json authorizer #389

Merged
merged 1 commit into from
Mar 29, 2020
Merged

feat(authz): Add remote_json authorizer #389

merged 1 commit into from
Mar 29, 2020

Conversation

kaorimatz
Copy link
Contributor

@kaorimatz kaorimatz commented Mar 28, 2020

Related issue

#201

Proposed changes

Add a new authorizer called remote_json proposed in #201 to support authorizing a request using an external service that doesn't implement the Keto's API interface.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

aeneasr added a commit to ory/docs that referenced this pull request Mar 29, 2020
@aeneasr aeneasr merged commit 45b9f8b into ory:master Mar 29, 2020
@kaorimatz kaorimatz deleted the feat-authz-add-remote-json-authorizer branch March 29, 2020 15:08
@mostafahussein
Copy link

mostafahussein commented Apr 22, 2020

@kaorimatz, How can I send the HTTP Verb (e.g. DELETE) to the remote_json authorizer? For example if the request was about deleting a book so it will look like this

curl -X DELETE http://oath-keeper/books

The remote_json authorizer currently receives /books only, So how can I validate against if the request is Get or Post or Delete and so on. So I can allow or deny based on the request http verb along with the resource

@aeneasr
Copy link
Member

aeneasr commented Apr 23, 2020

That's currently not possible but is a cool idea!

@mostafahussein
Copy link

@aeneasr I am trying to figure out what should be added/modified to that code so we can send the http_method (e.g. GET, POST). Any hints?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants