Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved WatchAndValidateViper to viperx #384

Merged
merged 8 commits into from
Mar 24, 2020

Conversation

zepatrik
Copy link
Member

Related issue

closes #342

@zepatrik
Copy link
Member Author

@aeneasr can you have a look why validation fails? The test runs with go1.13, local with go1.14 I get "additionalProperties \"errors\" not allowed" which does not make sense either.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why tests fail. Maybe flaky?

cmd/serve.go Outdated Show resolved Hide resolved
@zepatrik zepatrik requested a review from aeneasr March 24, 2020 16:46
@aeneasr aeneasr merged commit 12e0fc2 into master Mar 24, 2020
@aeneasr
Copy link
Member

aeneasr commented Mar 24, 2020

Awesome, thanks!

@aeneasr aeneasr deleted the improve-watching-viper-config branch May 7, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set array config options via environment variables
2 participants