-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable tracing #376
feat: Enable tracing #376
Conversation
Cool! Could you maybe add a jaeger example to the docker compose file similar to the way we have done it for Hydra (see code)? That would be super helpful to check out the feature! |
@aeneasr done! |
Awesome, thank you! |
FYI this capability isn't in the docs so it was a nice surprise to find this PR! Confirming though, this doesn't add the spans to outgoing requests from Oathkeeper does it? i.e. it won't allow be to continue tracing through to Hydra. |
@snikch does it work? I have set jaeger but I don't see oathkeeper requests to upstream or mutator |
@daviddelucca works fine for us |
I'm just seeing request for introspection. Are you able to find tracing for upstream host requests? |
@daviddelucca ah yes, correct. I added this separately here: #640 You'd need to have the equivalent code added to other endpoints I think. A bigger refactor would be to use a shared http client with tracing enabled so each separate area doesn't need to have it implemented. |
Proposed changes
Enable tracing via ory/x/tracing just like Hydra etc.
Checklist
vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.