Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #256: change error code from 403 to 401 #259

Merged
merged 7 commits into from
Sep 23, 2019
Merged

Conversation

ngrigoriev
Copy link
Contributor

Signed-off-by: Grigoriev, Nikolai [email protected]

#256

Proposed changes

  • added new field to the tests to check the status code for the errors
  • changed the status code to 401

Checklist

  • [x ] I have read the contributing guidelines
  • [x ] I have read the security policy
  • [ x] I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the
    developer guide (if appropriate)

Further comments

Documentation is already mentioning 401 so no updates are needed

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2019

CLA assistant check
All committers have signed the CLA.

@ngrigoriev
Copy link
Contributor Author

@aeneasr silly me, I have missed the e2e tests that need to be verified in addition to "go test ..."

@aeneasr aeneasr merged commit c17e564 into ory:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants