Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit adds sprig template library functions to the templates used in header/cookie mutator.
Go stdlib templates are very limited in terms of features. For example, I have a use case where I have an array of strings in session data, and I want to use mutator to join them into the single header string. Currently it is kind of impossible to do properly. This template almost does this, but there is no possibility on removing trailing comma:
With Extra set to
map[string]interface{}{"example.com/some-claims":[]string{"Foo","Bar"}
it compiles intoFoo,Bar,
.With sprig library we could replace the whole template with simple
{{- (index .Extra "example.com/some-claims") | join "," -}}
and it will produce correct outputFoo,Bar
.Sprig can also handle many other advanced use cases.
Checklist
vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.