Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rules in YAML format #213

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Conversation

hypnoglow
Copy link
Contributor

Proposed changes

This commit adds support for defining access rules in YAML format, in
addition to existing JSON format.

YAML is known as a superset of JSON.

This is useful in some cases, where YAML manipulation is preferable over JSON.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the
    developer guide (if appropriate)

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Only one nitpick :)

Oh and could you please document this in the oathkeeper docs, preferably in this file.

rule/fetcher_default_test.go Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Jun 26, 2019

Oh and please run make format :)

@hypnoglow
Copy link
Contributor Author

Oh and could you please document this in the oathkeeper docs, preferably in this file.

Sure, I will open a PR for docs soon.

This commit adds support for defining access rules in YAML format, in
addition to existing JSON format.
hypnoglow added a commit to hypnoglow/docs that referenced this pull request Jun 30, 2019
@hypnoglow
Copy link
Contributor Author

@aeneasr Done

aeneasr pushed a commit to ory/docs that referenced this pull request Jul 1, 2019
@aeneasr
Copy link
Member

aeneasr commented Jul 1, 2019

Thank you!

@aeneasr aeneasr merged commit 67face6 into ory:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants