proxy: add cookies credentials issuer #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Credentials Issuer is very similar to the Headers one, making it very easy to put together initially, but it was complicated a bit by all cookies being stored in a single HTTP header. Unfortunately the
AddCookie
method ofhttp.Header
will just keep appending cookies of the same name over and over and upstream has to just decide for itself which one to pay attention to, so I had to cache incoming request's cookies, remove them all, then re-add any that aren't being handled by the CI rule. This should prevent upstream from receiving spoofed cookies. Thus far testing this has proved stable.Cookie values are determined in the same way as headers, with
text/template
and aprint
FuncMap function: