Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected at least one private key #61

Closed
andre-perry-deidle opened this issue Apr 26, 2018 · 1 comment
Closed

Expected at least one private key #61

andre-perry-deidle opened this issue Apr 26, 2018 · 1 comment

Comments

@andre-perry-deidle
Copy link

When running the tests against a non-docker hydra (current master) I get the following:

=== RUN   TestManager/case=hydra
--- FAIL: TestManager (1.87s)
    --- PASS: TestManager/case=local (0.01s)
    --- FAIL: TestManager/case=hydra (1.86s)
        Error Trace:    manager_test.go:71
        Error:          Received unexpected error:
                        Expected at least one private key but got none
                        github.com/ory/oathkeeper/rsakey.(*HydraManager).Refresh
                                /home/andre/go2/src/github.com/ory/oathkeeper/rsakey/manager_hydra.go:68
                        github.com/ory/oathkeeper/rsakey.TestManager.func1
                                /home/andre/go2/src/github.com/ory/oathkeeper/rsakey/manager_test.go:71
                        testing.tRunner
                                /nix/store/d3vzj0lqdd879m812kpwzazzxzb27bik-go-1.10.1/share/go/src/testing/testing.go:777
                        runtime.goexit
                                /nix/store/d3vzj0lqdd879m812kpwzazzxzb27bik-go-1.10.1/share/go/src/runtime/asm_amd64.s:2361
        Test:           TestManager/case=hydra
FAIL
FAIL    github.com/ory/oathkeeper/rsakey        1.872s

It looks like there has been a change to generating the keys to use a GUID causing https://github.com/ory/oathkeeper/blob/master/rsakey/manager_hydra.go#L42 to not find it and loop generating initial RSA keys.

I hacked a fix by introducing a new key identifier. I see there are changes coming for hydra and was thinking of targeting the later code if possible.

@aeneasr
Copy link
Member

aeneasr commented May 23, 2018

This is fixed on master

@aeneasr aeneasr closed this as completed May 23, 2018
NickUfer pushed a commit to NickUfer/oathkeeper that referenced this issue Nov 11, 2020
Previously, the link for "Contact us" linked to the form edit page, which has now been fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants