Inconsistent Environment Variable Docs

[bensont1]

For consistency, should be HTTP_TLS_CERT_PATH and HTTP_TLS_KEY_PATH

certString, keyString := viper.GetString("HTTP_TLS_CERT"), viper.GetString("HTTP_TLS_KEY") certPath, keyPath := viper.GetString("HTTP_TLS_CERT_PATH"), viper.GetString("HTTP_TLS_KEY_PATH")

oathkeeper/cmd/helper_messages.go

Line 179 in 26fdda1

- HTTPS_TLS_CERT_PATH: The path to the TLS certificate (pem encoded).

[aeneasr]

I'm confused, isn't that the case already?

[aeneasr]

Oh, it's HTTP and HTTPS, thanks!

[bensont1]

@aeneasr Sorry I should have been more clear, the docs in helper_messages.go shows the Environment variable as HTTPS_TLS_CERT_PATH but the code uses HTTP_TLS_CERT_PATH. Since I was looking at only the docs initially, took me a little while to figure out why it wasn't using the certs. Just wanted to make sure other people who look at the docs don't go in a circle figuring it out :)

[fredbi]

To be consistent with hydra, I am going to move them all to HTTPS.
I let live the same inconsistent setup in keto.
ok to make this all HTTTPS_xxx like with hydra?

[bensont1]

Yeah it should be HTTPS, maybe only two T’s :) On Oct 11, 2018, at 12:20 AM, fredbi <[email protected]<mailto:[email protected]>> wrote: To be consistent with hydra, I am going to move them all to HTTPS. I let live the same inconsistent setup in keto. ok to make this all HTTTPS_xxx like with hydra? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#121 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFolT8gktFcbZZXAq2FPAEyceiQkaU49ks5ujvEwgaJpZM4W9sqv>.