fix: matcher.Match panic on nil *url.URL (#485)

Closes #484
ory · Jul 29, 2020 · ab27dda · ab27dda
1 parent 0b74414
commit ab27dda
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/rule/matcher_test.go b/rule/matcher_test.go
@@ -140,6 +140,11 @@ func TestMatcher(t *testing.T) {
 				assert.NotEmpty(t, got.matchingEngine.Checksum())
 			})
 
+			t.Run("case=nil url", func(t *testing.T) {
+				_, err := matcher.Match(context.Background(), "GET", nil)
+				require.Error(t, err)
+			})
+
 			require.NoError(t, matcher.Set(context.Background(), testRules[1:]))
 
 			t.Run("case=updated", func(t *testing.T) {

diff --git a/rule/repository_memory.go b/rule/repository_memory.go
@@ -120,6 +120,10 @@ func (m *RepositoryMemory) Set(ctx context.Context, rules []Rule) error {
 }
 
 func (m *RepositoryMemory) Match(_ context.Context, method string, u *url.URL) (*Rule, error) {
+	if u == nil {
+		return nil, errors.WithStack(errors.New("nil URL provided"))
+	}
+
 	m.Lock()
 	defer m.Unlock()