Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support to error handlers #70

Merged
merged 9 commits into from
Apr 25, 2023
Merged

feat: adding support to error handlers #70

merged 9 commits into from
Apr 25, 2023

Conversation

LeandroFranciscato
Copy link
Contributor

Related Issue or Design Document

Design Document issue:
#69

stale old issue:
#41

user slack question with no answer:
https://ory-community.slack.com/archives/C01340V8KSM/p1681971583368289

Oathkeeper errror handlers doc:
https://www.ory.sh/docs/oathkeeper/pipeline/error

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2023

CLA assistant check
All committers have signed the CLA.

@LeandroFranciscato LeandroFranciscato changed the title Adding support to error handlers feat: Adding support to error handlers Apr 25, 2023
@LeandroFranciscato LeandroFranciscato changed the title feat: Adding support to error handlers feat: adding support to error handlers Apr 25, 2023
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! We know how frustrating it can be to have your issues/requests hang in a limbo but we are currently too understaffed to be able to actively update the project 😞.
I have no issues with the PR and we could merge/release it as is, but i will leave a few possible improvements that could make this more future proof.

tests/integration/rules_test.go Outdated Show resolved Hide resolved
api/v1alpha1/rule_types_test.go Outdated Show resolved Hide resolved
api/v1alpha1/rule_types_test.go Outdated Show resolved Hide resolved
api/v1alpha1/rule_types_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Demonsthere Demonsthere merged commit 55619ed into ory:master Apr 25, 2023
@Demonsthere
Copy link
Collaborator

The release CI failed due to outdated github credentials, but the image was pushed to dockerhub :) https://hub.docker.com/layers/oryd/oathkeeper-maester/v0.1.8/images/sha256-4ad8cacfff71d9cd54a4247e91e2bbc8be7ccc953b2569fa2d4cd0dc68ea152e?context=explore
We can now bump the image and CRD in the k8s repo

@LeandroFranciscato
Copy link
Contributor Author

Cool.
I'm going to open the PR there.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants