-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support to error handlers #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution! We know how frustrating it can be to have your issues/requests hang in a limbo but we are currently too understaffed to be able to actively update the project 😞.
I have no issues with the PR and we could merge/release it as is, but i will leave a few possible improvements that could make this more future proof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
The release CI failed due to outdated github credentials, but the image was pushed to dockerhub :) https://hub.docker.com/layers/oryd/oathkeeper-maester/v0.1.8/images/sha256-4ad8cacfff71d9cd54a4247e91e2bbc8be7ccc953b2569fa2d4cd0dc68ea152e?context=explore |
Cool. |
Related Issue or Design Document
Design Document issue:
#69
stale old issue:
#41
user slack question with no answer:
https://ory-community.slack.com/archives/C01340V8KSM/p1681971583368289
Oathkeeper errror handlers doc:
https://www.ory.sh/docs/oathkeeper/pipeline/error
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments