-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cache OIDC providers #4222
Conversation
This change significantly reduces the number of requests to `/.well-known/openid-configuration` endpoints.
IMO a general HTTP client cache would make more sense. It can be used in lots of places. Based on https://github.com/gregjones/httpcache perhaps. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4222 +/- ##
==========================================
+ Coverage 78.52% 78.55% +0.03%
==========================================
Files 380 380
Lines 27231 27262 +31
==========================================
+ Hits 21383 21416 +33
+ Misses 4224 4223 -1
+ Partials 1624 1623 -1 ☔ View full report in Codecov by Sentry. |
I don't understand this PR. Where is the caching? |
…cache # Conflicts: # go.mod # go.sum
It's super hard to cache the full client responses correctly, so we added the cache to the go-oidc library instead. There we can do high-level caching. |
…cache # Conflicts: # go.mod # go.sum
This change significantly reduces the number of requests to
/.well-known/openid-configuration
endpoints.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments