Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing autocomplete attributes to identifier_first strategy #4215

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jonas-jonas
Copy link
Member

AFAICT, this setup adds proper support for password managers to the strategy. Though different PW managers and browsers handle this attribute differently, and it's not well documented what best to do. This combination is the only one that worked reliably.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas force-pushed the jonas-jonas/addMissingAutocomplete branch from fb6275b to 5b67f25 Compare November 18, 2024 12:56
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (82660f0) to head (5b67f25).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4215      +/-   ##
==========================================
+ Coverage   78.54%   78.56%   +0.01%     
==========================================
  Files         380      380              
  Lines       27225    27229       +4     
==========================================
+ Hits        21384    21392       +8     
+ Misses       4218     4216       -2     
+ Partials     1623     1621       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit e1f29c2 into master Nov 18, 2024
21 of 22 checks passed
@aeneasr aeneasr deleted the jonas-jonas/addMissingAutocomplete branch November 18, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants