Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: http courier should use lower case json #3740

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Feb 6, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr
Copy link
Member Author

aeneasr commented Feb 6, 2024

@jonas-jonas the payloads are currently uppercased and do not comply with our API design guidelines. This is a breaking change, can you please check if someone is using this already? We would need to inform them of these changes.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd79950) 78.27% compared to head (5335e2b) 78.30%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3740      +/-   ##
==========================================
+ Coverage   78.27%   78.30%   +0.03%     
==========================================
  Files         347      347              
  Lines       23813    23813              
==========================================
+ Hits        18639    18647       +8     
+ Misses       3762     3756       -6     
+ Partials     1412     1410       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr changed the title fix: http courier using should use lower case json fix: http courier should use lower case json Feb 9, 2024
@aeneasr aeneasr merged commit 84149c4 into master Feb 9, 2024
30 checks passed
@aeneasr aeneasr deleted the fix-upper-case-http-channel branch February 9, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant