Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more tracing to post-flow hooks #3566

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Oct 9, 2023

No description provided.

@zepatrik zepatrik requested review from aeneasr and hperl as code owners October 9, 2023 15:29
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #3566 (53a1dec) into master (9eff0f3) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 96.55%.

❗ Current head 53a1dec differs from pull request most recent head ac9be9f. Consider uploading reports for the commit ac9be9f to get more accurate results

@@            Coverage Diff             @@
##           master    #3566      +/-   ##
==========================================
+ Coverage   78.10%   78.14%   +0.03%     
==========================================
  Files         341      341              
  Lines       22820    22845      +25     
==========================================
+ Hits        17824    17852      +28     
+ Misses       3654     3653       -1     
+ Partials     1342     1340       -2     
Files Coverage Δ
selfservice/flow/login/hook.go 88.55% <100.00%> (+0.73%) ⬆️
x/http_secure_redirect.go 87.36% <100.00%> (ø)
selfservice/flow/registration/hook.go 74.69% <94.11%> (+1.85%) ⬆️

... and 1 file with indirect coverage changes

@zepatrik zepatrik merged commit e8b92c1 into master Oct 10, 2023
28 checks passed
@zepatrik zepatrik deleted the chore/after-login-tracing branch October 10, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants