Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow marking OIDC provider-verified addresses as verified during registration #3445

Closed

Conversation

Saancreed
Copy link
Contributor

Allows identities to skip address verification if Kratos is configured to trust OIDC providers to verify them ahead of time.

Related issue(s)

#3424

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

I chose to extend existing default OIDC provider configuration in tests instead of adding a new provider because the result is ignored if the schema doesn't have any verifiable addresses anyway and it was easier to do it this way (or so I believe). If you'd prefer to move the key under which verified_addresses are returned into identity object, like mentioned in linked issue, let me know and I'll change it.

@aeneasr
Copy link
Member

aeneasr commented Aug 22, 2023

ps: I changed the key from verified_addresses to identity.verified_addresses for JsonNet! Since I can't push to your fork, I created a new PR: #3448

@aeneasr
Copy link
Member

aeneasr commented Aug 22, 2023

Docs here: ory/docs#1511

@aeneasr aeneasr closed this in e7b33a1 Aug 22, 2023
@Saancreed Saancreed deleted the feat/oidc-preverified-addresses branch October 27, 2023 13:31
splaunov pushed a commit to monta-app/kratos that referenced this pull request Apr 23, 2024
…ng registration (ory#3448)

This feature allows marking emails provided by social sign in providers as verified.

Closes ory#3445
Closes ory#3424
Closes ory#1057

Co-authored-by: Krzysztof Bogacki <[email protected]>

(cherry picked from commit e7b33a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants