Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issuer missing from netid claims #3080

Merged
merged 5 commits into from
Feb 9, 2023
Merged

fix: issuer missing from netid claims #3080

merged 5 commits into from
Feb 9, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Feb 8, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner February 8, 2023 11:10
@aeneasr aeneasr self-assigned this Feb 8, 2023
The NetID provider omits the issuer claim in the userinfo response. To resolve this issue, the ID token returned by NetID is now validated and its `sub` and `iss` values are used.
@aeneasr aeneasr requested review from piotrmsc and removed request for zepatrik February 8, 2023 11:43
piotrmsc
piotrmsc previously approved these changes Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #3080 (42747c7) into master (8e87693) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

❗ Current head 42747c7 differs from pull request most recent head 49af440. Consider uploading reports for the commit 49af440 to get more accurate results

@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
- Coverage   77.25%   77.24%   -0.01%     
==========================================
  Files         314      314              
  Lines       19652    19662      +10     
==========================================
+ Hits        15182    15188       +6     
- Misses       3294     3296       +2     
- Partials     1176     1178       +2     
Impacted Files Coverage Δ
selfservice/strategy/oidc/provider_config.go 32.65% <0.00%> (ø)
selfservice/strategy/oidc/strategy.go 63.31% <ø> (ø)
selfservice/strategy/oidc/provider_netid.go 75.00% <63.15%> (-3.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit dec7cbc into master Feb 9, 2023
@aeneasr aeneasr deleted the net-id branch February 9, 2023 08:25
aeneasr added a commit that referenced this pull request Feb 9, 2023
The NetID provider omits the issuer claim in the userinfo response. To resolve this issue, the ID token returned by NetID is now validated and its `sub` and `iss` values are used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants