fix: Do not remove all credentials when remove all security keys #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
approved these changes
Feb 16, 2022
aeneasr
reviewed
Feb 16, 2022
Codecov Report
@@ Coverage Diff @@
## master #2233 +/- ##
==========================================
+ Coverage 75.84% 75.87% +0.03%
==========================================
Files 297 297
Lines 15905 15909 +4
==========================================
+ Hits 12063 12071 +8
+ Misses 2984 2979 -5
- Partials 858 859 +1
Continue to review full report at Codecov.
|
sawadashota
force-pushed
the
fix-2181
branch
from
d0cd751 to
00a906e
Compare
aeneasr
reviewed
Feb 18, 2022
selfservice/flow/settings/hook.go
Outdated
| @@ -223,6 +226,12 @@ func (e *HookExecutor) PostSettingsHook(w http.ResponseWriter, r *http.Request, | |||
| return nil | |||
| } | |||
|
|
|||
| x.ContentNegotiationRedirection(w, r, ctxUpdate.GetIdentityToUpdate().CopyWithoutCredentials(), e.d.Writer(), returnTo.String()) | |||
| i, ok := ctxUpdate.GetIdentityToUpdate() | |||
There was a problem hiding this comment.
Could you please add a test for these checks? :)
There was a problem hiding this comment.
This check is useless because there is ctxUpdate.UpdateIdentity(i) at line 166. So I removed these.
Signed-off-by: sawadashota <[email protected]>
Signed-off-by: sawadashota <[email protected]>
Signed-off-by: sawadashota <[email protected]>
aeneasr
approved these changes
Feb 20, 2022
This was referenced Mar 9, 2022
Merged
7 tasks
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
…#2233) Co-authored-by: aeneasr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Fix bug removing all credentials when remove all security keys.
Related: #2181
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
I'm sorry my previous PR #2181 fixes a bug but causes new bug.