Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to import user password credentials #2151

Closed
wants to merge 1 commit into from

Conversation

samcgardner
Copy link

@samcgardner samcgardner commented Jan 17, 2022

This change implements a very simple way of adding a user to Kratos with a known password, either in clear text or in one of the supported hashes. The user can also be added in a Verified status. This is intended to support a simple way of importing an existing user database.

I am submitting on behalf of a colleague due to previously discussed issues with internal approval.

Related issue(s)

Issue 605

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2022

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Jan 19, 2022

Thank you, this looks great! Could you please sign the CLA (just two clicks), then we can start with progressing on the review :)

@samcgardner samcgardner force-pushed the feat-import-credentials branch from 6d72f0d to 68da400 Compare January 31, 2022 10:28
@samcgardner samcgardner force-pushed the feat-import-credentials branch from 68da400 to 60e65f4 Compare January 31, 2022 10:41
@samcgardner samcgardner changed the title Add ability to import user password credentials feat: Add ability to import user password credentials Jan 31, 2022
@aeneasr aeneasr self-assigned this Feb 1, 2022
@alan994
Copy link

alan994 commented Feb 9, 2022

Any update on this? We really need this feature. Also, some support for extending hasher implementations would be great (perhaps in form of an external API call), but this is great for now.

@vinckr
Copy link
Member

vinckr commented Feb 9, 2022

Any update on this? We really need this feature. Also, some support for extending hasher implementations would be great (perhaps in form of an external API call), but this is great for now.

Hey Alan,
we don't give out concrete timelines for open source features, to protect our contributors and maintainers wellbeing.
That being said this is an important feature that will soon land, please be patient 🙏
We are also always open to contributions 👍
Also see our open source roadmap: https://www.ory.sh/docs/ecosystem/roadmap

@samcgardner
Copy link
Author

Hey ORY team, I just want to check you don't need any further input from me to drive this forward

@aeneasr
Copy link
Member

aeneasr commented Feb 23, 2022

Hey, I was looking into this issue today. It is a great starting point but there is still lots of work to be done. Besides tests, I think that the API format needs improvement to be more compatible with the default schema. It would also be good to be able to import some other credentials than the password. I saw that there are some changes to the packages that we can probably avoid (I suppose those were added due to some circular dependencies). I'm basing a new PR off of this one and see how far we get and tag you as a reviewer @samcgardner ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants