-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to import user password credentials #2151
Conversation
Thank you, this looks great! Could you please sign the CLA (just two clicks), then we can start with progressing on the review :) |
6d72f0d
to
68da400
Compare
…y to driver/config from hash
68da400
to
60e65f4
Compare
Any update on this? We really need this feature. Also, some support for extending |
Hey Alan, |
Hey ORY team, I just want to check you don't need any further input from me to drive this forward |
Hey, I was looking into this issue today. It is a great starting point but there is still lots of work to be done. Besides tests, I think that the API format needs improvement to be more compatible with the default schema. It would also be good to be able to import some other credentials than the password. I saw that there are some changes to the packages that we can probably avoid (I suppose those were added due to some circular dependencies). I'm basing a new PR off of this one and see how far we get and tag you as a reviewer @samcgardner ? :) |
This change implements a very simple way of adding a user to Kratos with a known password, either in clear text or in one of the supported hashes. The user can also be added in a Verified status. This is intended to support a simple way of importing an existing user database.
I am submitting on behalf of a colleague due to previously discussed issues with internal approval.
Related issue(s)
Issue 605
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.