Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include missing type string in config schema #2142

Merged
merged 1 commit into from
Jan 14, 2022
Merged

fix: include missing type string in config schema #2142

merged 1 commit into from
Jan 14, 2022

Conversation

David-van-der-Sluijs
Copy link
Contributor

Inside the config.schema.json under the CORS setting, add the missing type (string) for the items of the allowed_origins array.

I'm proposing this because I process this schema through a library, and this crucial missing piece of information leads to unexpected behavior.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Inside the config.schema.json under the CORS setting, add the missing type (string) for the items of the allowed_origins array
@CLAassistant
Copy link

CLAassistant commented Jan 13, 2022

CLA assistant check
All committers have signed the CLA.

@aeneasr aeneasr merged commit ec2c88a into ory:master Jan 14, 2022
@vinckr
Copy link
Member

vinckr commented Jan 17, 2022

Hello @SlateDave
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email to claim your Ory swag!

@David-van-der-Sluijs David-van-der-Sluijs deleted the patch-2 branch January 23, 2022 01:32
@vinckr vinckr mentioned this pull request Mar 18, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Inside the config.schema.json under the CORS setting, add the missing type (string) for the items of the allowed_origins array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants