Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update cypress #2090

Merged
merged 1 commit into from
Dec 30, 2021
Merged

test: update cypress #2090

merged 1 commit into from
Dec 30, 2021

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 30, 2021

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner December 30, 2021 16:22
@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #2090 (a491885) into master (f330df0) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
+ Coverage   74.97%   75.06%   +0.08%     
==========================================
  Files         293      293              
  Lines       15355    15355              
==========================================
+ Hits        11513    11526      +13     
+ Misses       3013     3005       -8     
+ Partials      829      824       -5     
Impacted Files Coverage Δ
persistence/sql/persister.go 76.92% <0.00%> (+2.19%) ⬆️
courier/courier.go 72.91% <0.00%> (+3.47%) ⬆️
persistence/sql/persister_courier.go 95.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f330df0...a491885. Read the comment docs.

@aeneasr aeneasr merged commit 883a1b1 into master Dec 30, 2021
@aeneasr aeneasr deleted the stop-cypress-flakes branch December 30, 2021 17:09
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant