Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docker guide #2089

Merged
merged 3 commits into from
Dec 30, 2021
Merged

docs: update docker guide #2089

merged 3 commits into from
Dec 30, 2021

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 30, 2021

Closes #2086

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #2089 (ed455d8) into master (f330df0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2089   +/-   ##
=======================================
  Coverage   74.97%   74.98%           
=======================================
  Files         293      293           
  Lines       15355    15355           
=======================================
+ Hits        11513    11514    +1     
+ Misses       3013     3012    -1     
  Partials      829      829           
Impacted Files Coverage Δ
driver/registry_default.go 86.23% <ø> (ø)
persistence/sql/persister.go 74.72% <ø> (ø)
persistence/sql/persister_identity.go 63.94% <ø> (+0.37%) ⬆️
persistence/sql/persister_login.go 100.00% <ø> (ø)
persistence/sql/persister_recovery.go 80.00% <ø> (ø)
persistence/sql/persister_transaction_helpers.go 100.00% <ø> (ø)
persistence/sql/persister_verification.go 77.77% <ø> (ø)
x/xsql/sql.go 92.30% <ø> (ø)
courier/test/persistence.go 100.00% <100.00%> (ø)
persistence/sql/persister_courier.go 85.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f330df0...ed455d8. Read the comment docs.

@aeneasr aeneasr merged commit 672c0ff into master Dec 30, 2021
@aeneasr aeneasr deleted the env-vars branch December 30, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant