Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error.id to invalid cookie/token settings flow #1919

Merged
merged 6 commits into from
Nov 8, 2021

Conversation

toonvanstrijp
Copy link
Contributor

Related issue(s)

#1888

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1919 (2bf9a7a) into master (3709345) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 2bf9a7a differs from pull request most recent head 8d8dc7e. Consider uploading reports for the commit 8d8dc7e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1919      +/-   ##
==========================================
+ Coverage   75.14%   75.20%   +0.06%     
==========================================
  Files         292      292              
  Lines       15241    15175      -66     
==========================================
- Hits        11453    11413      -40     
+ Misses       2964     2951      -13     
+ Partials      824      811      -13     
Impacted Files Coverage Δ
selfservice/flow/settings/handler.go 68.57% <0.00%> (ø)
courier/template/load_template.go 61.53% <0.00%> (-5.13%) ⬇️
persistence/sql/persister_courier.go 85.00% <0.00%> (-3.34%) ⬇️
courier/template/recovery_valid.go 100.00% <0.00%> (ø)
courier/template/verification_valid.go 100.00% <0.00%> (ø)
internal/testhelpers/e2e_server.go 89.56% <0.00%> (+1.73%) ⬆️
schema/handler.go 84.48% <0.00%> (+1.94%) ⬆️
selfservice/strategy/link/sender.go 76.82% <0.00%> (+5.55%) ⬆️
x/map_json.go 87.09% <0.00%> (+7.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3709345...8d8dc7e. Read the comment docs.

@aeneasr aeneasr merged commit 73610d4 into ory:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants