Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hash): Add PBKDF2 as password hashing algorithm #1774

Merged
merged 24 commits into from
Oct 25, 2021
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
132260c
feat(hash): Add PBKDF2 as password hashing algorithm
sawadashota Sep 22, 2021
ef29b25
docs: Add configuration docs for PBKDF2 hasher
sawadashota Sep 22, 2021
3589872
fix: Upgrade to other algorithm from PBKDF2
sawadashota Sep 23, 2021
0d5efdc
Add test for password hash algorithm upgrade
sawadashota Sep 23, 2021
369b509
fix: Configurable which algorithm is upgrade to from PBKDF2
sawadashota Sep 27, 2021
61ff7e7
fix: PBKDF2 encoded body respects Django style
sawadashota Sep 27, 2021
ea81e4c
fix: Parse uint32 string
sawadashota Sep 27, 2021
c5fa8df
Update docs
sawadashota Sep 27, 2021
2c6b1f8
fix: PBKDF2 test
sawadashota Sep 29, 2021
07a897b
fix: login flow test
sawadashota Sep 29, 2021
2ace692
Document abount PBKDF2 format
sawadashota Sep 29, 2021
9a5bfe6
fix: Auto-upgrade password hash algorithm to `hashers.algorithm`
sawadashota Oct 4, 2021
1afc1f5
fix: migrate password hash method name
sawadashota Oct 4, 2021
97777e0
Document about auto-migration
sawadashota Oct 4, 2021
7bd1c82
Add tests
sawadashota Oct 5, 2021
9699a1f
fix: Encoding format for PBKDDF2
sawadashota Oct 13, 2021
30b1b5c
Add test using upper case `i`
sawadashota Oct 13, 2021
b572366
Merge branch 'master' into feat-1659
sawadashota Oct 19, 2021
6e7ed6f
chore: code review
aeneasr Oct 19, 2021
2815d1a
chore: Add doc about import credentials
sawadashota Oct 21, 2021
338afb9
chore(docs): Stored hash password format
sawadashota Oct 21, 2021
486660a
chore: Format docs
sawadashota Oct 21, 2021
0baeccb
fix: Use raw string for gosimple lint
sawadashota Oct 21, 2021
9c09126
Merge branch 'master' into feat-1659
aeneasr Oct 25, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Document about auto-migration
Signed-off-by: sawadashota <[email protected]>
sawadashota committed Oct 13, 2021
commit 97777e0c69c70df64a365112134765c70d8ab564
3 changes: 2 additions & 1 deletion docs/docs/reference/configuration.md
Original file line number Diff line number Diff line change
@@ -1909,7 +1909,8 @@ hashers:

## Password hashing algorithm ##
#
# One of the values: argon2, bcrypt
# One of the values: argon2, bcrypt.
# If database stores a password hashed by another algorithm, the password will be migrated to this algorithm when user logins using password flow.
#
# Default value: bcrypt
#
2 changes: 1 addition & 1 deletion embedx/config.schema.json
Original file line number Diff line number Diff line change
@@ -1767,7 +1767,7 @@
"properties": {
"algorithm": {
"title": "Password hashing algorithm",
"description": "One of the values: argon2, bcrypt",
"description": "One of the values: argon2, bcrypt.\nIf database stores a password hashed by another algorithm, the password will be migrated to this algorithm when user logins using password flow.",
"type": "string",
"default": "bcrypt",
"enum": [