Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovery link answers with JSON payload for API flows #2049

Closed
6 tasks done
aeneasr opened this issue Dec 10, 2021 · 3 comments · Fixed by #2250
Closed
6 tasks done

Recovery link answers with JSON payload for API flows #2049

aeneasr opened this issue Dec 10, 2021 · 3 comments · Fixed by #2250
Assignees
@Demonsthere
Labels
bug Something is not working.
Milestone
v0.8.0-alpha.1

Comments

@aeneasr
Copy link
Member

aeneasr commented Dec 10, 2021

Preflight checklist

Describe the bug

When initializing a recovery or verification link using an API flow, and then clicking on the link, the browser shows a JSON instead of the UI

Reproducing the bug

Not sure yet

Relevant log output

No response

Relevant configuration

No response

Version

v0.8.0-alpha.4

On which operating system are you observing this issue?

No response

In which environment are you deploying?

No response

Additional Context

No response
@aeneasr aeneasr added the bug Something is not working. label Dec 10, 2021
@aeneasr aeneasr self-assigned this Dec 10, 2021
@aeneasr aeneasr added this to the v0.8.0-alpha.1 milestone Dec 10, 2021
@aeneasr aeneasr removed their assignment Jan 17, 2022
@aeneasr
Copy link
Member Author

aeneasr commented Jan 21, 2022

Reported by @sashatalalasha

@aeneasr aeneasr assigned Benehiko and unassigned Benehiko Feb 5, 2022
@Demonsthere
Copy link
Contributor

Context: issue related to link expiration.

@Demonsthere
Copy link
Contributor

Demonsthere commented Feb 22, 2022 •
edited
Loading

Judging from the JSON response sample, the request_url was missing the return_to parameter:

"request_url":"http://foobar.com/self-service/registration/api?return_to="

@Demonsthere Demonsthere mentioned this issue Feb 23, 2022
Merged
7 tasks
aeneasr added a commit that referenced this issue Feb 25, 2022
@Demonsthere @zepatrik @aeneasr
fix: don't inherit flow type in recovery and verification flows (#2250)
c5b444a 
Closes #2049

Co-authored-by: Patrik <[email protected]>
Co-authored-by: aeneasr <[email protected]>
Co-authored-by: Patrik <[email protected]>
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this issue Jun 30, 2023
@Demonsthere @zepatrik @aeneasr
fix: don't inherit flow type in recovery and verification flows (ory#…
2ea4448 
…2250)

Closes ory#2049

Co-authored-by: Patrik <[email protected]>
Co-authored-by: aeneasr <[email protected]>
Co-authored-by: Patrik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Demonsthere Demonsthere

Labels
bug Something is not working.
Projects
None yet
Milestone
v0.8.0-alpha.1
Development

Successfully merging a pull request may close this issue.

fix: don't inherit flow type in recovery and verification flows Demonsthere/kratos
3 participants
@aeneasr @Demonsthere @Benehiko