Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: selfservice/admin session management #2011

Merged
merged 21 commits into from
Jan 4, 2022
Merged

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Nov 30, 2021

Related issue(s)

closes #655
closes #2007

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@zepatrik zepatrik changed the title feat: selfservice session management feat: selfservice/admin session management Dec 1, 2021
@zepatrik zepatrik marked this pull request as ready for review December 3, 2021 12:45
@zepatrik zepatrik requested a review from aeneasr as a code owner December 3, 2021 12:45
session/handler.go Outdated Show resolved Hide resolved
@zepatrik zepatrik requested a review from aeneasr December 9, 2021 15:05
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #2011 (117dd35) into master (4a3e2df) will decrease coverage by 0.01%.
The diff coverage is 82.49%.

❗ Current head 117dd35 differs from pull request most recent head 8edbde1. Consider uploading reports for the commit 8edbde1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2011      +/-   ##
==========================================
- Coverage   75.04%   75.03%   -0.02%     
==========================================
  Files         293      293              
  Lines       15374    15568     +194     
==========================================
+ Hits        11538    11681     +143     
- Misses       3008     3047      +39     
- Partials      828      840      +12     
Impacted Files Coverage Δ
identity/handler.go 86.27% <ø> (ø)
schema/handler.go 82.53% <ø> (ø)
session/persistence.go 0.00% <ø> (ø)
x/pagination.go 100.00% <ø> (ø)
session/handler.go 70.06% <54.54%> (-18.25%) ⬇️
persistence/sql/persister_session.go 80.70% <77.27%> (-2.16%) ⬇️
session/test/persistence.go 100.00% <100.00%> (ø)
selfservice/flow/registration/handler.go 70.68% <0.00%> (-6.17%) ⬇️
identity/identity_verification.go 65.00% <0.00%> (-3.97%) ⬇️
courier/courier.go 69.44% <0.00%> (-3.48%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3e2df...8edbde1. Read the comment docs.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the URL structure a bit to conform the rest of the codebase better. Otherwise, this is good to merge but should get a bit of docs :)

docs/docs/guides/login-session.mdx Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Jan 3, 2022

pop v6 😅

@aeneasr aeneasr merged commit 0fe4155 into master Jan 4, 2022
@aeneasr aeneasr deleted the feat/session-management branch January 4, 2022 09:02
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide user last login time as a part of user identities list response Admin/Selfservice session management
3 participants