WIP: Refresh session param for whoami endpoint, PLATFORM-6607 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
harnash
reviewed
Jan 4, 2022
session/handler.go
Outdated
| // Redirect to public endpoint | ||
| admin.Handle(m, RouteWhoami, x.RedirectToPublicRoute(h.r)) | ||
| } | ||
| admin.DELETE(RouteIdentityManagement, h.deleteIdentitySessions) | ||
| admin.PATCH(RouteSession, h.adminSessionRefresh) |
There was a problem hiding this comment.
Wouldn't it be more sensible to have session refresh only on PATCH method? GET should be non-mutable.
harnash
force-pushed
the
PLATFORM-6607-prolong-session
branch
from
92383e9 to
85a92a1
Compare
harnash
force-pushed
the
PLATFORM-6607-prolong-session
branch
from
85a92a1 to
9479410
Compare
abador
commented
Jan 12, 2022
|
Can you make a PR against our repo? :) |
|
Ah got it, will take a look to confirm |
aeneasr
reviewed
Jan 12, 2022
| @@ -178,6 +183,15 @@ func (h *Handler) whoami(w http.ResponseWriter, r *http.Request, ps httprouter.P | |||
| return | |||
| } | |||
|
|
|||
| // Refresh session if param was true | |||
| refresh := r.URL.Query().Get("refresh") | |||
7 tasks
Co-authored-by: Mikołaj Meller <[email protected]>
Co-authored-by: Mikołaj Meller <[email protected]>
| - oryAccessToken: [] | ||
| summary: |- | ||
| Calling this endpoint refreshes a current user session. | ||
| If `session.refresh_time_window` is set it will only refresh the session after this time has passed. |
There was a problem hiding this comment.
Suggested change
| If `session.refresh_time_window` is set it will only refresh the session after this time has passed. | |
| If `session.refresh_min_time_left` is set it will only refresh the session after this time has passed. |
abador
force-pushed
the
PLATFORM-6607-prolong-session
branch
from
3be64f1 to
0caadac
Compare
mmeller-wikia
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to refresh a currently used session in the whoami endpoint.
Issue tracked in upstream: #615
Admin part is based on this pr: #2011