fix: courier

ory · Dec 6, 2021 · 488640c · 488640c
1 parent 9ec6b70
commit 488640c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/cmd/courier/watch.go b/cmd/courier/watch.go
@@ -2,14 +2,16 @@ package courier
 
 import (
 	cx "context"
+	"net/http"
+
+	"github.com/spf13/cobra"
+	"github.com/urfave/negroni"
+
 	"github.com/ory/graceful"
 	"github.com/ory/kratos/driver"
 	"github.com/ory/kratos/x"
 	"github.com/ory/x/configx"
 	"github.com/ory/x/reqlog"
-	"github.com/spf13/cobra"
-	"github.com/urfave/negroni"
-	"net/http"
 )
 
 func NewWatchCmd() *cobra.Command {

diff --git a/courier/courier.go b/courier/courier.go
@@ -31,7 +31,7 @@ type (
 	SMTPDependencies interface {
 		PersistenceProvider
 		x.LoggingProvider
-		CourierConfig(ctx context.Context) SMTPConfig
+		ConfigProvider
 	}
 	TemplateTyper            func(t EmailTemplate) (TemplateType, error)
 	EmailTemplateFromMessage func(c SMTPConfig, msg Message) (EmailTemplate, error)
@@ -44,6 +44,9 @@ type (
 	Provider interface {
 		Courier(ctx context.Context) *Courier
 	}
+	ConfigProvider interface {
+		CourierConfig(ctx context.Context) SMTPConfig
+	}
 )
 
 func NewSMTP(ctx context.Context, d SMTPDependencies) *Courier {

diff --git a/driver/registry_default.go b/driver/registry_default.go
@@ -7,6 +7,8 @@ import (
 	"sync"
 	"time"
 
+	"github.com/gobuffalo/pop/v5"
+
 	"github.com/ory/nosurf"
 
 	"github.com/ory/kratos/selfservice/strategy/webauthn"
@@ -22,8 +24,6 @@ import (
 
 	prometheus "github.com/ory/x/prometheusx"
 
-	"github.com/gobuffalo/pop/v5"
-
 	"github.com/ory/kratos/cipher"
 	"github.com/ory/kratos/continuity"
 	"github.com/ory/kratos/hash"
@@ -260,10 +260,7 @@ func (m *RegistryDefault) Config(ctx context.Context) *config.Config {
 }
 
 func (m *RegistryDefault) CourierConfig(ctx context.Context) courier.SMTPConfig {
-	if m.c == nil {
-		panic("configuration not set")
-	}
-	return corp.ContextualizeConfig(ctx, m.c)
+	return m.Config(ctx)
 }
 
 func (m *RegistryDefault) SMTPConfig(ctx context.Context) courier.SMTPConfig {