Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make sensitive log value redaction text configurable #3040

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

aarmam
Copy link
Contributor

@aarmam aarmam commented Mar 18, 2022

This pull request introduces feature to configure sensitive log value redaction text. Current redaction text "Value is sensitive and has been redacted. To see the value set config key "log.leak_sensitive_values = true" or environment variable "LOG_LEAK_SENSITIVE_VALUES=true"." is too long and takes considerable amount of log space.

Related issue(s)

ory/x#482

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@aarmam aarmam requested a review from aeneasr as a code owner March 18, 2022 11:02
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to update go.mod to use the new ory/x :)

Could you please add these to keto and kratos as well :)

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #3040 (8962d91) into master (9eabc7d) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3040      +/-   ##
==========================================
+ Coverage   79.40%   79.42%   +0.02%     
==========================================
  Files         112      112              
  Lines        7889     7889              
==========================================
+ Hits         6264     6266       +2     
+ Misses       1223     1222       -1     
+ Partials      402      401       -1     
Impacted Files Coverage Δ
persistence/sql/persister_oauth2.go 81.85% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9338e4...8962d91. Read the comment docs.

@aarmam aarmam force-pushed the feature/configurable-redaction-text branch from b1d69bc to 8962d91 Compare March 18, 2022 12:43
@aeneasr aeneasr merged commit 536352c into ory:master Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants