feat: allow custom access token ttl #656
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Hi team,
Please pardon me if I misunderstood the code. I have been trying to configure OAuth2.0
access_token
which has a configurable TTL or expiration time. After trying different methods which didn't work. I stumbled upon this issue thehotfix
provided does work. But I thought it would be better to add this.The PR adds logic to override the default configured access token lifespan if a value for
expiresAt
is provided (SetExpiresAt
) through the request session.Happy to have your input on this and make changes based of feedback. Thanks!
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
appropriate).
Further comments