Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve regression #561

Merged
merged 1 commit into from
Feb 5, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion authorize_request.go
Original file line number Diff line number Diff line change
@@ -49,10 +49,11 @@ type AuthorizeRequest struct {
func NewAuthorizeRequest() *AuthorizeRequest {
return &AuthorizeRequest{
ResponseTypes: Arguments{},
RedirectURI: &url.URL{},
HandledResponseTypes: Arguments{},
Request: *NewRequest(),
ResponseMode: ResponseModeDefault,
// The redirect URL must be unset / nil for redirect detection to work properly:
// RedirectURI: &url.URL{},
}
}

5 changes: 5 additions & 0 deletions authorize_request_test.go
Original file line number Diff line number Diff line change
@@ -22,13 +22,18 @@
package fosite

import (
"github.com/stretchr/testify/require"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order of imports?

"net/url"
"testing"
"time"

"github.com/stretchr/testify/assert"
)

func TestAuthorizeRequestURLRegression(t *testing.T) {
require.Nil(t, NewAuthorizeRequest().RedirectURI)
}

func TestAuthorizeRequest(t *testing.T) {
var urlparse = func(rawurl string) *url.URL {
u, _ := url.Parse(rawurl)