Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement client token lifespan customization #684

Merged

Conversation

grantzvolsky
Copy link
Contributor

@grantzvolsky grantzvolsky commented Jul 19, 2022

This change introduces the ability to control the lifespan of tokens for each valid combination of Client, GrantType, and TokenType.

Part of ory/hydra#3157

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

Further comments

@aeneasr aeneasr force-pushed the feature/client-token-lifespan-customization branch from c93812e to 62f83d0 Compare July 19, 2022 11:44
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looking great! From my side, can be merged as is

@aeneasr aeneasr mentioned this pull request Jul 19, 2022
5 tasks
@grantzvolsky grantzvolsky force-pushed the feature/client-token-lifespan-customization branch from 62f83d0 to 2c80e62 Compare July 30, 2022 22:38
grantzvolsky and others added 3 commits July 31, 2022 00:45
This change introduces the ability to control the lifespan of tokens for each valid combination of Client, GrantType, and TokenType.

Part of ory/hydra#3157
@grantzvolsky grantzvolsky force-pushed the feature/client-token-lifespan-customization branch from 2c80e62 to 5a2b37e Compare July 30, 2022 22:48
@grantzvolsky grantzvolsky marked this pull request as ready for review July 30, 2022 22:55
@aeneasr aeneasr merged commit cfffe8c into ory:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants