fix: resolve regression (#561)

ory · Feb 5, 2021 · 173d60e · 173d60e
1 parent c2375de
commit 173d60e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/authorize_request.go b/authorize_request.go
@@ -49,10 +49,11 @@ type AuthorizeRequest struct {
 func NewAuthorizeRequest() *AuthorizeRequest {
 	return &AuthorizeRequest{
 		ResponseTypes:        Arguments{},
-		RedirectURI:          &url.URL{},
 		HandledResponseTypes: Arguments{},
 		Request:              *NewRequest(),
 		ResponseMode:         ResponseModeDefault,
+		// The redirect URL must be unset / nil for redirect detection to work properly:
+		// RedirectURI:          &url.URL{},
 	}
 }
 

diff --git a/authorize_request_test.go b/authorize_request_test.go
@@ -22,13 +22,18 @@
 package fosite
 
 import (
+	"github.com/stretchr/testify/require"
 	"net/url"
 	"testing"
 	"time"
 
 	"github.com/stretchr/testify/assert"
 )
 
+func TestAuthorizeRequestURLRegression(t *testing.T) {
+	require.Nil(t, NewAuthorizeRequest().RedirectURI)
+}
+
 func TestAuthorizeRequest(t *testing.T) {
 	var urlparse = func(rawurl string) *url.URL {
 		u, _ := url.Parse(rawurl)