feat: Use id from https://graph.microsoft.com/v1.0/me as oidc subject. #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
aeneasr
reviewed
Mar 28, 2022
docs/kratos/guides/sign-in-with-github-google-facebook-linkedin.mdx
Outdated
Show resolved
Hide resolved
…n.mdx Co-authored-by: hackerman <[email protected]>
aeneasr
reviewed
Mar 28, 2022
| @@ -560,6 +560,7 @@ selfservice: | |||
| client_id: .... # Replace this with the Application ID from the App Registration | |||
| client_secret: .... # Replace this with the generated Secret value from the App Registration | |||
| microsoft_tenant: .... # Replace this with the Tenant of your choice (see below) | |||
| subject_source: userinfo | |||
There was a problem hiding this comment.
Suggested change
| subject_source: userinfo | |
| subject_source: userinfo # or alternatively: me |
aeneasr
added a commit
that referenced
this pull request
Mar 28, 2022
…#715) Closes #706 Co-authored-by: splaunov <[email protected]> Co-authored-by: Sergey Plaunov <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
#2150
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
appropriate).
Further comments