Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update docs for md5 hashing #1090

Merged
merged 5 commits into from
Dec 1, 2022
Merged

docs: update docs for md5 hashing #1090

merged 5 commits into from
Dec 1, 2022

Conversation

erolkskn
Copy link
Contributor

It fulfills missing documents for the PR: ory/kratos#2725

@erolkskn erolkskn changed the title feat: update docs for md5 hashing docs: update docs for md5 hashing Nov 21, 2022
aeneasr
aeneasr reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! @tomekpapiernik LGTY?

@tomekpapiernik tomekpapiernik self-requested a review November 23, 2022 08:35
tomekpapiernik
tomekpapiernik suggested changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@tomekpapiernik tomekpapiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @erolkskn ! Please help me figure out the details of the salted format as it's a bit confusing - might be caused the way the text is structured but I'm not 100% sure so I'd appreciate it if you answer my questions.

docs/kratos/concepts/credentials/username-email-password.mdx Outdated Show resolved Hide resolved
docs/kratos/concepts/credentials/username-email-password.mdx Outdated Show resolved Hide resolved
docs/kratos/concepts/credentials/username-email-password.mdx Outdated Show resolved Hide resolved
docs/kratos/concepts/credentials/username-email-password.mdx Outdated Show resolved Hide resolved
docs/kratos/concepts/credentials/username-email-password.mdx Outdated Show resolved Hide resolved
docs/kratos/concepts/credentials/username-email-password.mdx Outdated Show resolved Hide resolved
docs/kratos/concepts/credentials/username-email-password.mdx Outdated Show resolved Hide resolved
docs/kratos/concepts/credentials/username-email-password.mdx Outdated Show resolved Hide resolved
docs/kratos/concepts/credentials/username-email-password.mdx Outdated Show resolved Hide resolved
docs/kratos/manage-identities/25_import-user-accounts-identities.mdx Outdated Show resolved Hide resolved
@elbotho elbotho mentioned this pull request Nov 23, 2022
Merged
7 tasks
@tomekpapiernik
Copy link
Contributor

Hi @erolkskn, hope you're doing great after the weekend :) Pinging you to see how are things coming along with this PR. Do you need any help introducing the edits we discussed? I'm here to help if you need me. Cheers!

@erolkskn
Copy link
Contributor Author

Hi @erolkskn, hope you're doing great after the weekend :) Pinging you to see how are things coming along with this PR. Do you need any help introducing the edits we discussed? I'm here to help if you need me. Cheers!

Hi @tomekpapiernik. Thanks, it was good, wishing you had great weekend as well 😄 About the PR, I'm going to have free time tonight. So, it ought to be ready for another review by this night.

@tomekpapiernik
Copy link
Contributor

Hi @erolkskn!

We've tweaked the docs during the time you were working on this PR which caused conflicts on this PR.
I took the liberty of resolving the conflicts and tweaking the writing just a tiny bit. I have now approved this PR and will merge it once all tests pass.

Thanks again for your contribution! 🎉

@tomekpapiernik tomekpapiernik merged commit 8754db1 into ory:master Dec 1, 2022
tomekpapiernik added a commit that referenced this pull request Dec 5, 2022
@erolkskn @tomekpapiernik
docs: update docs for md5 hashing (#1090)
c41d9e8 
* docs: update docs for md5 hashing

Signed-off-by: Erol Keskin <[email protected]>

* Apply suggestions from code review

Co-authored-by: Tom Papiernik <[email protected]>

* refactor

* chore: maintainer edits

Signed-off-by: Erol Keskin <[email protected]>
Co-authored-by: Tom Papiernik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr left review comments

@tomekpapiernik tomekpapiernik tomekpapiernik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erolkskn @tomekpapiernik @aeneasr