Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Remove go-dockerclient dependency #122

Merged
merged 6 commits into from
Apr 11, 2018
Merged

vendor: Remove go-dockerclient dependency #122

merged 6 commits into from
Apr 11, 2018

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Apr 11, 2018

No description provided.

@aeneasr
Copy link
Member Author

aeneasr commented Apr 11, 2018

ping @dennwc

@aeneasr aeneasr merged commit 2e92e77 into v3 Apr 11, 2018
@aeneasr aeneasr deleted the fix-deps branch April 11, 2018 18:02
@johanbrandhorst
Copy link

I'm confused by this. Did you simply copy the vendored package into your own directory? What is the point of that?

@aeneasr
Copy link
Member Author

aeneasr commented Apr 12, 2018

go-dockerclient had a dependency on docker-swarm which pulled a ton of external dependencies. Instead of forking go-dockerclient I vendored the docker dependency here and removed the swarm capabilities which we don't need anyways. Still has some dependencies to smaller repos but we can strip them as time passes

@aeneasr
Copy link
Member Author

aeneasr commented Apr 12, 2018

Another issue addressed by this is the ridiculous instability of dep and the docker repository in general. I got failing builds everywhere because dep was unable to copy some unrelated go files (.pem test fixtures). Vendoring it in here will resolve this, but we might have to update this if docker releases breaking changes.

@johanbrandhorst
Copy link

I see. Have you considered just forking go-dockerclient instead and using that repo as a proper vendor directory?

@aeneasr
Copy link
Member Author

aeneasr commented Apr 12, 2018

Yes, I did. I don't want to give the impression though that it's officially maintained and an alternative to go-dockerclient because it's not.

@aeneasr
Copy link
Member Author

aeneasr commented Apr 12, 2018

I would also prefer to just use http.DefaultClient to talk to Docker but I don't have the time to dig in and it also seems like there's more to it (like handling their streams, properly reading auth data, ...)

xstevens pushed a commit to xstevens/dockertest that referenced this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants