Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): add number prop for vmodel casting #884

Merged
merged 27 commits into from
Jun 12, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Apr 3, 2024

Part of #835

Proposed Changes

  • Update vue-docgen-cli
  • Add dynamic modelValue type defined by number property for o-input component
  • Input values are of string type by default, even with type="number". To cast the input value to a number type, the new property number must be set

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 8f0a82d
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6669545d9610680008e24d45
😎 Deploy Preview https://deploy-preview-884--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.13%. Comparing base (484cfe8) to head (8f0a82d).
Report is 92 commits behind head on develop.

Files Patch % Lines
packages/oruga/src/components/input/Input.vue 75.00% 2 Missing and 1 partial ⚠️
...oruga/src/components/autocomplete/Autocomplete.vue 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #884       +/-   ##
============================================
- Coverage    56.71%   30.13%   -26.59%     
============================================
  Files           30      295      +265     
  Lines         1511     7685     +6174     
  Branches       544     2137     +1593     
============================================
+ Hits           857     2316     +1459     
- Misses         654     4651     +3997     
- Partials         0      718      +718     
Flag Coverage Δ
oruga-next 30.13% <78.26%> (-26.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek added the enhancement Improvements to existing features and functionality label May 3, 2024
@mlmoravek mlmoravek changed the title feat(input): update input vmodel type definition feat(input): add number prop for vmodel casting Jun 12, 2024
@mlmoravek mlmoravek merged commit ded99f9 into oruga-ui:develop Jun 12, 2024
9 of 11 checks passed
@mlmoravek mlmoravek deleted the generics/input branch June 12, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant